Dependencies: put upper limit markupsafe<2.1
#5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release `markupsafe==2.1` breaks `jinja<3.0` and that in turn breaks `sphinx<4.0`. Upgrading to `sphinx~=4.0` brings its own problems with a whole host of new warnings that cannot be easily fixed and so instead we are putting an upper limit on `markupsafe`.
|
I originally tried to fix this issue in #5369 by just upping all involved dependencies (dependency chain is |
csadorf
approved these changes
Feb 21, 2022
sphuber
added a commit
that referenced
this pull request
Mar 7, 2022
The latest release `markupsafe==2.1` breaks `jinja<3.0` and that in turn breaks `sphinx<4.0`. Upgrading to `sphinx~=4.0` brings its own problems with a whole host of new warnings that cannot be easily fixed and so instead we are putting an upper limit on `markupsafe`. Cherry-pick: 139f7d2
sphuber
added a commit
that referenced
this pull request
Mar 7, 2022
The latest release `markupsafe==2.1` breaks `jinja<3.0` and that in turn breaks `sphinx<4.0`. Upgrading to `sphinx~=4.0` brings its own problems with a whole host of new warnings that cannot be easily fixed and so instead we are putting an upper limit on `markupsafe`. Cherry-pick: 139f7d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5367
The latest release
markupsafe==2.1breaksjinja<3.0and that inturn breaks
sphinx<4.0. Upgrading tosphinx~=4.0brings its ownproblems with a whole host of new warnings that cannot be easily fixed
and so instead we are putting an upper limit on
markupsafe.