Docs: replace CircleCI build with ReadTheDocs #5279
Conversation
|
I've just turned on the RTD PR builds then. |
Also did that already, but build doesn't seem to get triggered here. Do we need to configure a webhook here in this repo explicitly? EDIT: never mind, I did this on the old |
|
Perhaps you didn't save it, because it was selected when I went to the settings. |
Don't even know what this is lol |
sphuber
force-pushed
the
fix/4104/replace-circle-ci
branch
from
c9504e6 to
562e15a
Compare
It is this package. Those are the docs for the |
|
Retriggered the CI but I don't see it triggering the RTD build |
|
ok give it another go |
The documentation was being built on CircleCI instead of GHA like the rest of the CI pipeline, because the former would allow the built HTML documentation to be inspected as an artifact, whereas for the latter this wasn't possible. It is now possible to do the same with ReadTheDocs, and since we already use that to host the documentation, that means we can now drop CircleCI.
sphuber
force-pushed
the
fix/4104/replace-circle-ci
branch
from
562e15a to
f76d3be
Compare
|
there you go 👍 |
What did you change? |
|
magic! (add PR events to the webhook) |
The documentation was being built on CircleCI instead of GHA like the rest of the CI pipeline, because the former would allow the built HTML documentation to be inspected as an artifact, whereas for the latter this wasn't possible. It is now possible to do the same with ReadTheDocs, and since we already use that to host the documentation, that means we can now drop CircleCI. Cherry-pick: 7fad822
The documentation was being built on CircleCI instead of GHA like the rest of the CI pipeline, because the former would allow the built HTML documentation to be inspected as an artifact, whereas for the latter this wasn't possible. It is now possible to do the same with ReadTheDocs, and since we already use that to host the documentation, that means we can now drop CircleCI. Cherry-pick: 7fad822
Fixes #4104
The documentation was being built on CircleCI instead of GHA like the
rest of the CI pipeline, because the former would allow the built
HTML documentation to be inspected as an artifact, whereas for the
latter this wasn't possible.
It is now possible to do the same with ReadTheDocs, and since we already
use that to host the documentation, that means we can now drop CircleCI.