Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Allow Graph to be used by any backend #5200

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

chrisjsewell
Copy link
Member

This is a follow-up to #5186,
to ensure Graph always uses the initialised Backend.

This is a follow-up to #5186,
to ensure `Graph` always uses the initialised `Backend`.
@chrisjsewell
Copy link
Member Author

chrisjsewell commented Oct 27, 2021

With this change, the Graph works correctly in #5145, for the archive backend, when no profile is loaded

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #5200 (c225599) into develop (ea3ab28) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5200      +/-   ##
===========================================
- Coverage    81.00%   80.99%   -0.00%     
===========================================
  Files          535      535              
  Lines        37402    37404       +2     
===========================================
+ Hits         30292    30293       +1     
- Misses        7110     7111       +1     
Flag Coverage Δ
django 75.82% <60.00%> (-<0.01%) ⬇️
sqlalchemy 74.92% <60.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/tools/visualization/graph.py 82.48% <60.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3ab28...c225599. Read the comment docs.

@chrisjsewell chrisjsewell merged commit 5530589 into develop Oct 27, 2021
@chrisjsewell chrisjsewell deleted the chrisjsewell-patch-1 branch October 27, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant