Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Add typing to all base Entity classes #5185

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

chrisjsewell
Copy link
Member

AuthInfo, Comment, Computer, Group, Log, Node, and User.
Also remove uuid from BackendNode, since it is not available for AuthInfo and User.

Also remove `uuid` from `BackendNode`, since it is not available for `AuthInfo` and `User`.
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #5185 (68b7e1a) into develop (fc0b458) will increase coverage by 0.01%.
The diff coverage is 92.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5185      +/-   ##
===========================================
+ Coverage    81.00%   81.00%   +0.01%     
===========================================
  Files          535      535              
  Lines        37289    37376      +87     
===========================================
+ Hits         30202    30274      +72     
- Misses        7087     7102      +15     
Flag Coverage Δ
django 75.82% <92.08%> (+0.02%) ⬆️
sqlalchemy 74.91% <92.08%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/orm/implementation/users.py 100.00% <ø> (ø)
aiida/orm/authinfos.py 83.34% <83.34%> (-2.87%) ⬇️
aiida/orm/implementation/computers.py 73.47% <85.72%> (+2.05%) ⬆️
aiida/orm/utils/loaders.py 88.15% <85.72%> (-0.25%) ⬇️
aiida/orm/implementation/entities.py 98.09% <88.89%> (-0.57%) ⬇️
aiida/orm/comments.py 91.08% <89.48%> (-2.11%) ⬇️
aiida/orm/computers.py 81.64% <92.99%> (-0.31%) ⬇️
aiida/orm/logs.py 92.78% <93.34%> (-0.37%) ⬇️
aiida/orm/groups.py 94.12% <93.75%> (-0.92%) ⬇️
aiida/orm/users.py 87.63% <95.46%> (+1.75%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0b458...68b7e1a. Read the comment docs.

@chrisjsewell chrisjsewell merged commit 23981a5 into aiidateam:develop Oct 20, 2021
@chrisjsewell chrisjsewell deleted the type-base-entities branch October 20, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant