Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Entity Collection typing #5183

Merged
merged 10 commits into from
Oct 20, 2021
Prev Previous commit
Update computers.py
chrisjsewell committed Oct 20, 2021

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ulyssa Ulyssa
commit 0ae56a1da4a8e1465d803452f693d7477f379594
3 changes: 1 addition & 2 deletions aiida/orm/computers.py
Original file line number Diff line number Diff line change
@@ -36,7 +36,6 @@ def get_or_create(self, label: Optional[str] = None, **kwargs) -> Tuple['Compute
create (and store) a new Computer if such a Computer was not present yet.

:param label: computer label
:type label: str

:return: (computer, created) where computer is the computer (new or existing,
in any case already stored) and created is a boolean saying
@@ -53,7 +52,7 @@ def list_labels(self) -> List[str]:
"""Return a list with all the labels of the computers in the DB."""
return self._backend.computers.list_names()

def delete(self, pk: int):
def delete(self, pk: int) -> None:
"""Delete the computer with the given id"""
return self._backend.computers.delete(pk)