-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Default to number of physical cores for localhost code. #5161
Conversation
Adjust how the "localhost" code is configured on the aiida-core Docker image. The default value is based on the actual number of physical cores and is further configurable via an environment variable. Closes #5117.
e2cc6fe
to
dee2486
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5161 +/- ##
===========================================
- Coverage 80.93% 80.91% -0.02%
===========================================
Files 536 536
Lines 37056 37056
===========================================
- Hits 29989 29979 -10
- Misses 7067 7077 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @csadorf , some comments below
And allow for explicit user override even in the case of success. The number of logical cores servers only as the default value.
748700b
to
e42b916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @csadorf . All good, I just think you forgot to replace one occurrence of MPI_PROCS_PER_MACHINE
. Once corrected this can be merged.
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Looks like a git conflict resolution went wrong... |
No idea why the tests are not passing anymore. |
They were not even running because Github Actions is in degraded mode: https://www.githubstatus.com/ |
Adjust how the "localhost" code is configured on the aiida-core Docker
image. The default value is based on the actual number of physical cores
and is further configurable via an environment variable.
Closes #5117.