Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👌 IMPROVE: Add Dict.__ne__ #5150

Closed
wants to merge 2 commits into from
Closed

👌 IMPROVE: Add Dict.__ne__ #5150

wants to merge 2 commits into from

Conversation

chrisjsewell
Copy link
Member

See #5142 (comment)

@sphuber still not sure what the "default" comparison should be; I you put self is other for __eq__, was there a reason for this?

@chrisjsewell chrisjsewell marked this pull request as draft September 23, 2021 12:22
@chrisjsewell chrisjsewell removed the request for review from sphuber September 23, 2021 12:23
@sphuber sphuber mentioned this pull request Oct 4, 2021
Merged
@sphuber
Copy link
Contributor

sphuber commented Oct 4, 2021

Closing this in favor of #5159

@sphuber sphuber closed this Oct 4, 2021
@sphuber sphuber deleted the chrisjsewell-patch-1 branch October 6, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisjsewell @sphuber