verdi process list: fix logging bug in check_worker_load
#5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/5144/logging-check-worker-load
branch
from
3c65979 to
ab64234
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5147 +/- ##
===========================================
+ Coverage 80.89% 80.90% +0.01%
===========================================
Files 536 536
Lines 37019 37019
===========================================
+ Hits 29943 29945 +2
+ Misses 7076 7074 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sphuber
force-pushed
the
fix/5144/logging-check-worker-load
branch
from
ab64234 to
b77a3b7
Compare
sphuber
force-pushed
the
fix/5144/logging-check-worker-load
branch
from
b77a3b7 to
8a66038
Compare
The `check_worker_load` utility, called in `verdi process list`, caused an exception in the logging because it logged a message including a literal percentage sign. However, percentage signs carry special meaning as they are placeholders for argument substitution and literal percentage signs need to be escaped by doubling the character.
sphuber
force-pushed
the
fix/5144/logging-check-worker-load
branch
from
eb97d25 to
1071ae6
Compare
ramirezfranciscof
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5144
The
check_worker_loadutility, called inverdi process list, causedan exception in the logging because it logged a message including a
literal percentage sign. However, percentage signs carry special meaning
as they are placeholders for argument substitution and literal
percentage signs need to be escaped by doubling the character.