Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump aiida-prerequisites #5134

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Sep 13, 2021

This includes an upgrade from Ubuntu 18.04 to 20.04.

Also remove installation of custom circus dependency (issue was fixed in
circus 17.0).

This includes an upgrade from Ubuntu 18.04 to 20.04.

Also remove installation of custom circus dependency (issue was fixed in
circus 17.0).
@ltalirz ltalirz requested a review from yakutovicha September 13, 2021 20:13
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #5134 (88b9454) into develop (22d4e2e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5134      +/-   ##
===========================================
+ Coverage    80.88%   80.88%   +0.01%     
===========================================
  Files          536      536              
  Lines        37057    37057              
===========================================
+ Hits         29970    29971       +1     
+ Misses        7087     7086       -1     
Flag Coverage Δ
django 75.72% <ø> (ø)
sqlalchemy 74.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/transports/plugins/local.py 81.66% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d4e2e...88b9454. Read the comment docs.

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of checks failing and it looks like the change of the Python version requires an update of the Jenkins CI job.

.jenkins/Jenkinsfile Show resolved Hide resolved
@csadorf csadorf self-requested a review September 14, 2021 07:42
@ltalirz ltalirz merged commit d7d1ac6 into aiidateam:develop Sep 14, 2021
ltalirz added a commit that referenced this pull request Sep 14, 2021
This includes an upgrade from Ubuntu 18.04 to 20.04
(and thus an upgrade of Python from 3.7 to 3.8).

Also remove installation of custom circus dependency (issue was fixed in
circus 17.0).

Cherry-pick: d7d1ac6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants