⬆️ UPGRADE: psycopg2 allow v2.9

[chrisjsewell]

Fixed in aiidateam/pgsu#27

fixes #5002

[chrisjsewell]

will just need to wait for the conda release of pgsu v0.2.1 (can merge the automated conda-forge PR as soon as it pops up)

[csadorf]

Approved pending that all tests pass. Please let me know if there appears to be an issue with the test-install workflow.

[chrisjsewell]

eurhhh; ran into another problem; psycopg/psycopg2#1293, which is not being fixed for django v2: django/django#14530

oh well, guess I'll have to fix the issue by dropping django 😉

[chrisjsewell]

should just need to implement the try/finally, to close the connection, in tests/backends/aiida_sqlalchemy/migrations/conftest.py::uninitialised_profile

[sphuber]

should just need to implement the try/except, to close the connection, in tests/backends/aiida_sqlalchemy/migrations/conftest.py::uninitialised_profile

Do you mean try/finally?

It is interesting that it is the migration tests that fail in the first PR after merging them, while I was working on creating a nightly workflow to move them to since we said "the migration tests shouldn't break very often" 😅

[chrisjsewell]

It is interesting that it is the migration tests that fail in the first PR after merging them

Well, creating an "empty" profile (configured to an empty database/repository), for the duration of a test, then deleting it, is not really tied to migrations.
Its just a standard action that django did not allow, because we could only create a single, global database connection.

[chrisjsewell]

while I was working on creating a nightly workflow to move them to

FYI, tox tests/backends/aiida_sqlalchemy/migrations, takes about 2:30 minutes for me, so I'm not sure if it definitely needs to be moved to nightly.

For sure, the polish tests should be at least moved to a separate job though

[sphuber]

For sure, the polish tests should be at least moved to a separate job though

Well if you think 2:30 is not a problem, then the polish also don't have to be moved. Running the two of them takes ~4:20. It is not a huge difference, but still I think it might make sense not to require those additional minutes on every commit.

[chrisjsewell]

then the polish also don't have to be moved.

But the polish workchains (i.e. integration testing) is completely separate to the unit tests whereas, for example, codecov would report much lower code coverage if we moved chunks of unit tests to separate jobs

[codecov]

Codecov Report

Merging #5104 (0f85a6c) into develop (842d47d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #5104      +/-   ##
===========================================
+ Coverage    82.03%   82.06%   +0.03%     
===========================================
  Files          512      512              
  Lines        36792    36792              
===========================================
+ Hits         30179    30189      +10     
+ Misses        6613     6603      -10     

Impacted Files	Coverage Δ
aiida/transports/plugins/local.py	81.71% <0.00%> (+0.26%)	⬆️
aiida/orm/nodes/process/calculation/calcjob.py	78.00% <0.00%> (+0.96%)	⬆️
aiida/engine/processes/calcjobs/tasks.py	65.78% <0.00%> (+1.01%)	⬆️
aiida/engine/processes/calcjobs/manager.py	86.73% <0.00%> (+3.54%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842d47d...0f85a6c. Read the comment docs.

[sphuber]

Good to go as far as I am concerned