Remove superfluous _validate from Data node #5089
Conversation
ltalirz
force-pushed
the
fix-validation
branch
from
1d392aa to
43523cf
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5089 +/- ##
===========================================
- Coverage 80.71% 80.71% -0.00%
===========================================
Files 534 534
Lines 36967 36966 -1
===========================================
- Hits 29835 29834 -1
Misses 7132 7132
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ltalirz
force-pushed
the
fix-validation
branch
from
43523cf to
6020005
Compare
The Data nodeclass overwrote the `_validate` function but (a) did no validation (b) included commented code that referenced a private git repository (c) returned `None` instead of `True`. The outcommented code involved validation of the `source` attribute and the referenced issue pointed out that the value of this attribute was not officially standardized (potentially leading users to using it in different ways). Since there has not been validation of this field since 2015, it seems safe to assume that it cannot be easily reintroduced at this point.
ltalirz
force-pushed
the
fix-validation
branch
from
6020005 to
67dab0f
Compare
There was a problem hiding this comment.
Hey @ltalirz ! Just one little comment but other than that this looks good to go for me, ping me if you need final approval once you rebase/update.
Co-authored-by: Francisco Ramirez <ramirezfranciscof@users.noreply.github.com>
|
thanks, done! |
|
Mmm strange i thought that would fix the CI doc problem. Do you understand what is wrong with this? I'll try compiling the docs locally. |
Co-authored-by: Francisco Ramirez <ramirezfranciscof@users.noreply.github.com>
|
thanks a lot! |
|
sure, please go ahead! |
The Data nodeclass overwrote the
_validatefunction but(a) did no validation
(b) included commented code that referenced a private git repository
(c) returned
Noneinstead ofTrue.The outcommented code involved validation of the
sourceattribute andthe referenced issue pointed out that the value of this attribute was
not officially standardized (potentially leading users to using it in
different ways).
Since there has not been validation of this field since 2015, it seems
safe to assume that it cannot be easily reintroduced at this point.