Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 TESTS: Convert tests/orm/test_querybuilder.py to pytest #5079

Merged
merged 2 commits into from
Aug 15, 2021

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Aug 13, 2021

See #4782 (comment) for process

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #5079 (33fcb92) into develop (3a6c77e) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5079      +/-   ##
===========================================
- Coverage    80.46%   80.42%   -0.04%     
===========================================
  Files          531      531              
  Lines        36969    36969              
===========================================
- Hits         29745    29727      -18     
- Misses        7224     7242      +18     
Flag Coverage Δ
django 74.90% <ø> (-0.08%) ⬇️
sqlalchemy 73.85% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/backends/general/abstractqueries.py 59.68% <0.00%> (-4.03%) ⬇️
aiida/orm/implementation/django/groups.py 82.86% <0.00%> (-2.14%) ⬇️
aiida/orm/groups.py 92.99% <0.00%> (-1.75%) ⬇️
aiida/orm/implementation/sqlalchemy/groups.py 86.09% <0.00%> (-1.03%) ⬇️
...iida/orm/implementation/sqlalchemy/querybuilder.py 81.04% <0.00%> (-0.57%) ⬇️
aiida/orm/querybuilder.py 81.75% <0.00%> (-0.47%) ⬇️
aiida/transports/plugins/local.py 81.41% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6c77e...33fcb92. Read the comment docs.

@chrisjsewell chrisjsewell changed the title 🧪 TESTS: convert tests/orm/test_querybuilder.py to pytest 🧪 TESTS: Convert tests/orm/test_querybuilder.py to pytest Aug 14, 2021
@chrisjsewell chrisjsewell merged commit 3915f44 into aiidateam:develop Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant