Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise Docker image build: #4997

Merged
merged 6 commits into from
Jun 30, 2021
Merged

Revise Docker image build: #4997

merged 6 commits into from
Jun 30, 2021

Conversation

yakutovicha
Copy link
Contributor

  • Build a new image on every PR (with caching).
  • Test the functionality of the new image on every PR.
  • Build a new image on every commit to develop/master branch and every
    time a new tag is created (no caching).

@yakutovicha
Revise Docker image build:
9466a2e 
* Build a new image on every PR (with caching).
* Test the functionality of the new image on every PR.
* Build a new image on every commit to develop/master branch and every
time a new tag is created (no caching).
@codecov
Copy link

codecov bot commented Jun 25, 2021 •
edited
Loading

Codecov Report

Merging #4997 (0f77621) into develop (f2367e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4997   +/-   ##
========================================
  Coverage    80.13%   80.13%           
========================================
  Files          515      515           
  Lines        36692    36692           
========================================
  Hits         29398    29398           
  Misses        7294     7294
Flag Coverage Δ
django 74.60% <ø> (+0.01%) ⬆️
sqlalchemy 73.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2367e9...0f77621. Read the comment docs.

@yakutovicha yakutovicha requested a review from chrisjsewell June 28, 2021 07:38
@yakutovicha
Copy link
Contributor Author

An important thing to note: we need somebody to put their Dockerhub credentials in GitHub secrets: DOCKER_USERNAME and DOCKER_TOKEN. Who wants to be that somebody? Maybe @giovannipizzi?

@yakutovicha
Copy link
Contributor Author

An important thing to note: we need somebody to put their Dockerhub credentials in GitHub secrets: DOCKER_USERNAME and DOCKER_TOKEN. Who wants to be that somebody? Maybe @giovannipizzi?

I added my own Docker Hub username and token. Feel free to change it.

chrisjsewell
chrisjsewell suggested changes Jun 30, 2021
View reviewed changes
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yakutovicha, just a minor nitpick

.github/workflows/push_image_to_dockerhub.yml Outdated Show resolved Hide resolved
@yakutovicha @chrisjsewell
Update .github/workflows/push_image_to_dockerhub.yml
0f77621 
Co-authored-by: Chris Sewell <chrisj_sewell@hotmail.com>
@yakutovicha yakutovicha merged commit 9c7ffc2 into aiidateam:develop Jun 30, 2021
@yakutovicha yakutovicha deleted the update/switch-docker-build-to-github-actions branch June 30, 2021 10:01
sphuber pushed a commit to sphuber/aiida-core that referenced this pull request Oct 5, 2021
@yakutovicha @sphuber
Revise Docker image build (aiidateam#4997).
6742f75 
* Build a new image on every PR (with caching).
* Test the functionality of the new image on every PR.
* Build a new image on every commit to develop/master branch and every
time a new tag is created (no caching).

Co-authored-by: Chris Sewell <chrisj_sewell@hotmail.com>

Cherry-pick: 9c7ffc2
@chrisjsewell chrisjsewell mentioned this pull request Mar 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjsewell chrisjsewell chrisjsewell approved these changes

@ramirezfranciscof ramirezfranciscof Awaiting requested review from ramirezfranciscof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yakutovicha @chrisjsewell