Rename name column of Computer database table to label

[sphuber]

Fixes #2926

All other database models already use label so using the same for the
Computer model is more consistent. The name attribute was already
deprecated in the ORM in aiida-core==1.0.0 and replaced by label.
Here we apply the actual database migration to also perform the change
in the database models.

[sphuber]

I started the deprecation path for this change in v1.0.0 by adding label in our front-end ORM and raising deprecation warnings when name was used. However, we could not provide a deprecation path for all uses. Most notably, when using the QueryBuilder one had to continue to use name when specifying it in the filters or projections. The same goes for the REST API, where name is still being used. With this PR, the database tables are updated to use label and the final remnants of name are removed. This does mean, however, that this will break code that manually uses the QueryBuilder to query for computers and filter or project on name, so this could be an argument to not merge these changes.

However, on the other hand, currently there is an inconsistency where in the ORM one has to use label whereas in the REST API and QB one should use name. By merging these changes, we get rid of this inconsistency.

[codecov]

Codecov Report

Merging #4882 (2d14abf) into develop (c7897c5) will increase coverage by 0.02%.
The diff coverage is 87.63%.

@@             Coverage Diff             @@
##           develop    #4882      +/-   ##
===========================================
+ Coverage    80.08%   80.10%   +0.02%     
===========================================
  Files          514      517       +3     
  Lines        36576    36617      +41     
===========================================
+ Hits         29288    29327      +39     
- Misses        7288     7290       +2     

Flag	Coverage Δ
django	74.57% <58.77%> (-0.02%)	⬇️
sqlalchemy	73.51% <65.98%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiida/backends/sqlalchemy/models/authinfo.py	88.47% <0.00%> (ø)
aiida/orm/implementation/computers.py	68.43% <ø> (ø)
aiida/orm/implementation/django/convert.py	75.87% <ø> (ø)
aiida/backends/djsite/db/models.py	81.40% <25.00%> (ø)
aiida/backends/sqlalchemy/models/computer.py	92.31% <50.00%> (ø)
aiida/orm/implementation/sqlalchemy/computers.py	76.25% <66.67%> (ø)
aiida/orm/computers.py	81.42% <80.00%> (+0.17%)	⬆️
aiida/orm/implementation/django/computers.py	77.78% <80.00%> (ø)
...ools/importexport/archive/migrations/v11_to_v12.py	88.89% <88.89%> (ø)
...jsite/db/migrations/0048_computer_name_to_label.py	100.00% <100.00%> (ø)
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7897c5...2d14abf. Read the comment docs.

[sphuber]

@ramirezfranciscof @chrisjsewell this is now ready for review

[ltalirz]

thanks @sphuber !

I went through the files and the changes all look fine.
It's a pity that we we could not do a deprecation for the querybuilder and the REST API, so some people might run into issues, but this change needs to happen and it should happen in 2.0.

I notice that the file tests/static/graphs/graph1.aiida was deleted - was this just no longer needed?

[ltalirz]

to be fully consistent, one might argue that display_name should become display_label.
but I'm ok with keeping this inconsistency

[sphuber]

I notice that the file tests/static/graphs/graph1.aiida was deleted - was this just no longer needed?

It wasn't deleted, it was just migrated since it needed to also perform the name -> label change in the archive. Due to the new archive format that is already there, the size was just reduced.