Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update archive version: 0.9 -> 0.10 #4561

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Nov 12, 2020

fixes #4560

@chrisjsewell chrisjsewell requested a review from ltalirz November 12, 2020 21:51
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chrisjsewell , this looks good to me

one test is failing, I guess there is one more export file to migrate

@chrisjsewell chrisjsewell requested a review from ltalirz November 13, 2020 09:53
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #4561 (23866b4) into develop (def9a03) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4561      +/-   ##
===========================================
+ Coverage    79.41%   79.41%   +0.01%     
===========================================
  Files          481      482       +1     
  Lines        35279    35287       +8     
===========================================
+ Hits         28012    28021       +9     
+ Misses        7267     7266       -1     
Flag Coverage Δ
django 73.58% <100.00%> (+0.02%) ⬆️
sqlalchemy 72.75% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ida/tools/importexport/dbimport/backends/django.py 92.94% <ø> (-0.07%) ⬇️
aiida/tools/importexport/dbimport/backends/sqla.py 93.71% <ø> (-0.06%) ⬇️
.../tools/importexport/archive/migrations/__init__.py 100.00% <100.00%> (ø)
...ools/importexport/archive/migrations/v09_to_v10.py 100.00% <100.00%> (ø)
aiida/tools/importexport/common/config.py 100.00% <100.00%> (ø)
aiida/engine/daemon/runner.py 82.76% <0.00%> (+3.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def9a03...23866b4. Read the comment docs.

@chrisjsewell chrisjsewell changed the title Add archive migration: 0.9 -> 0.10 Update archive version: 0.9 -> 0.10 Nov 13, 2020
@chrisjsewell chrisjsewell merged commit 810dc56 into aiidateam:develop Nov 13, 2020
@chrisjsewell chrisjsewell deleted the archive/bump_version branch November 13, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.9 archives with group extras not importable on aiida v1.4.2
2 participants