-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reset
method toProgressReporterAbstract
#4522
Add reset
method toProgressReporterAbstract
#4522
Conversation
I've tested this against my 40,000 node archive, and looks to be all be working as expected:
|
3a99078
to
e830297
Compare
This commit adds the update method to the progress reporter. This in-turn, allows for the implmentation of a callback mechanism in `ArchiveReaderAbstract.iter_node_repos`. The callback implmentation is taken from the [disk-objectstore](https://github.com/aiidateam/disk-objectstore) package, and so facilitates a later migration to its use. The commit also moves the common repository import code out of the backend specific modules, reducing code duplication.
e830297
to
3754353
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4522 +/- ##
===========================================
+ Coverage 79.39% 79.40% +0.01%
===========================================
Files 480 480
Lines 35080 35087 +7
===========================================
+ Hits 27850 27858 +8
+ Misses 7230 7229 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions before approving (see comments)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chrisjsewell !
This PR adds the
update
method to the progress reporter.This in-turn, allows for the implmentation of a callback mechanism in
ArchiveReaderAbstract.iter_node_repos
.The callback implmentation is taken from the disk-objectstore package, and so facilitates a later migration to its use.
The PR also moves the (common) repository import code out of the backend specific modules, reducing code duplication.
This PR is intended to facilitate the transition to the new node repository in #4345