Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #4416 #4519

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Revert PR #4416 #4519

merged 1 commit into from
Oct 27, 2020

Conversation

ramirezfranciscof
Copy link
Member

This PR reverts the changes made in commit 16bc305. (Titled: "CalcJob: support nested directories in target of remote_copy/symlink_list (#4416)"). The reasons for the reversal is that apparently part of the behavior of the copy lists may have been inadvertidly changed; this needs to be explored so that we know in more details these behavior and then the feature can re-introduced after we can be more certain it won't break backwards compatibility.

"`CalcJob`: support nested directories in target of `remote_copy/symlink_list` (aiidateam#4416)"

This reverts commit 16bc305.
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #4519 into develop will decrease coverage by 0.05%.
The diff coverage is 57.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4519      +/-   ##
===========================================
- Coverage    79.35%   79.31%   -0.04%     
===========================================
  Files          476      476              
  Lines        34959    34958       -1     
===========================================
- Hits         27738    27723      -15     
- Misses        7221     7235      +14     
Flag Coverage Δ
#django 73.16% <57.15%> (-0.05%) ⬇️
#sqlalchemy 72.41% <57.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/engine/daemon/execmanager.py 62.13% <57.15%> (-5.66%) ⬇️
aiida/engine/daemon/runner.py 79.32% <0.00%> (-3.44%) ⬇️
aiida/manage/tests/pytest_fixtures.py 89.48% <0.00%> (-1.75%) ⬇️
aiida/transports/plugins/local.py 81.54% <0.00%> (-1.02%) ⬇️
aiida/orm/utils/log.py 93.34% <0.00%> (+16.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c8afa...44a4a4e. Read the comment docs.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sphuber sphuber merged commit 9460e4e into aiidateam:develop Oct 27, 2020
@sphuber sphuber deleted the revertcopy branch October 27, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants