Querybuilder init now accepts entity_type = '' #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4299 +/- ##
===========================================
+ Coverage 72.83% 79.21% +6.39%
===========================================
Files 468 468
Lines 34559 34559
===========================================
+ Hits 25166 27374 +2208
+ Misses 9393 7185 -2208
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sphuber
requested changes
Aug 12, 2020
There was a bug when using the queryhelp of a previously defined QueryBuilder which was appended a single query for the generic "Node" class as a template in the initialization for a new query. The underlying problem was that the append method was doing the wrong checks to detect missing cls/entity_type. Also modified a test to check for this specific case.
ramirezfranciscof
force-pushed
the
issue4248
branch
from
36e9309 to
72ae63f
Compare
|
@sphuber very sorry for the commented leftovers, I had to take a break between making it work and preparing the PR and in the middle I forgot to take those out. Now it should be ready, I will re-request your final review once all the CI tests pass. |
sphuber
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when using the queryhelp of a previously defined
QueryBuilder which was appended a single query for the generic "Node"
class as a template in the initialization for a new query.
The underlying problem was that the append method was doing the wrong
checks to detect missing cls/entity_type.
Also added a test for this new specific case.
Fixes #4248