Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/hide stubs #4137

Merged
merged 1 commit into from
May 29, 2020
Merged

Docs/hide stubs #4137

merged 1 commit into from
May 29, 2020

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented May 29, 2020

No description provided.

@csadorf csadorf requested a review from sphuber May 29, 2020 17:14
@csadorf csadorf force-pushed the docs/hide-stubs branch from 56dd543 to ba98e14 Compare May 29, 2020 17:14
@csadorf csadorf added this to the Publish revised documentation milestone May 29, 2020
sphuber
sphuber requested changes May 29, 2020
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also still quite a few in source/internals and source/topics. You can search for `# in your codebase to find them

@csadorf csadorf force-pushed the docs/hide-stubs branch 3 times, most recently from c128478 to a597793 Compare May 29, 2020 17:40
@sphuber
Copy link
Contributor

sphuber commented May 29, 2020

I am seeing a lot of warning on the CircleCI build. Could you build this locally?

@csadorf
Copy link
Contributor Author

csadorf commented May 29, 2020

I am seeing a lot of warning on the CircleCI build. Could you build this locally?

Working on it, I'll re-request review when it's ready.

@csadorf csadorf force-pushed the docs/hide-stubs branch 2 times, most recently from 91bc9b0 to bba85e0 Compare May 29, 2020 18:05
@csadorf
Copy link
Contributor Author

csadorf commented May 29, 2020

@sphuber This should be ok now. There are still warnings, but it's because it's based on docs-revamp without #4135 .

@csadorf csadorf requested a review from sphuber May 29, 2020 18:12
@csadorf csadorf force-pushed the docs/hide-stubs branch from bba85e0 to e5db12f Compare May 29, 2020 18:25
@csadorf csadorf merged commit 3d171d5 into aiidateam:docs-revamp May 29, 2020
@csadorf csadorf deleted the docs/hide-stubs branch May 29, 2020 18:27
csadorf added a commit that referenced this pull request Jun 2, 2020
@csadorf
Convert all stubs of missing sections into todo items. (#4137)
8c25cfe 
Using the 'todo::' directive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber Awaiting requested review from sphuber

Assignees
No one assigned
Labels
topic/documentation
Projects
None yet
Milestone
Publish revised documentation
Development

Successfully merging this pull request may close these issues.
2 participants
@csadorf @sphuber