Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding short note on multiple users' usage #4109

Merged
merged 4 commits into from
May 26, 2020

Conversation

giovannipizzi
Copy link
Member

This will be extended in the future when better multiuser support will be available

Fixes #4005

@giovannipizzi giovannipizzi requested a review from csadorf May 25, 2020 11:29
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giovannipizzi . The way you describe it here, we are essentially saying that we don't support multi-user configurations. Having each user install their own instance does not count. If that is what we want to do, I think we should make this more explicit. Something like the following as a first sentence. "Setups with multiple users for a single AiiDA instance is currently not supported".

That being said, even though we don't have a formal multi-user system in place, there are certain ways to have some kind of multiple user setups. I feel it might still be useful to note these here, albeit with a fat disclaimer of the relevant caveats. Would you agree?

docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
giovannipizzi and others added 2 commits May 25, 2020 22:44
This will be extended in the future when better multiuser support will be available
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
@giovannipizzi
Copy link
Member Author

I have accepted the suggestion, and removed the note on UUIDs vs PKs.
Instead, as discussed, for now I will not expand on ways to have multiple user-setup as I never tested them, or some of the other options might not guarantee enough security. We can always extend this section later, if we want.

This is ready to be reviewed again (and merged - I have rebased).

@giovannipizzi giovannipizzi linked an issue May 25, 2020 that may be closed by this pull request
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giovannipizzi some minor changes and then I will merge this

docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine and I agree with @sphuber 's comments. I'll approve once those comments are addressed and the merge conflict is resolved.

@giovannipizzi
Copy link
Member Author

Should be done now

@csadorf
Copy link
Contributor

csadorf commented May 26, 2020

@sphuber Please merge at your discretion.

@sphuber sphuber merged commit d50545b into aiidateam:docs-revamp May 26, 2020
csadorf pushed a commit that referenced this pull request May 29, 2020
Currently, we state that multiple user setups for single AiiDA instances
are not officially supported, and until we do, we do not describe the
ways that people have used multiple users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: How to manage multiple users
3 participants