Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add howto on plugins #4078

Merged
merged 3 commits into from
May 19, 2020
Merged

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented May 17, 2020

fixes #4006
fixes #4008
fixes #4009
fixes #4007
fixes #4023

add "How to package plugins":

  • add "Creating a plugin package"
  • add "Adding entry points"
  • add "Testing a plugin package"
  • add "Documenting a plugin package"
  • add "Publishing a plugin package"

Also start adding the "plugins" topical guide.

add "How to package plugins":

 * add "Creating a plugin package"
 * add "Adding entry points"
 * add "Testing a plugin package"
 * add "Documenting a plugin package"
 * add "Publishing a plugin package"

Also start adding the "plugins" topical guide.
@ltalirz ltalirz requested a review from sphuber May 17, 2020 20:42
@ltalirz ltalirz requested a review from csadorf May 18, 2020 07:40
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I provided some comments and suggestions.

docs/source/howto/codes.rst Show resolved Hide resolved
docs/source/howto/codes.rst Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/plugins.rst Outdated Show resolved Hide resolved
docs/source/howto/plugins.rst Outdated Show resolved Hide resolved
docs/source/topics/plugins.rst Outdated Show resolved Hide resolved
docs/source/topics/plugins.rst Outdated Show resolved Hide resolved
docs/source/topics/plugins.rst Outdated Show resolved Hide resolved
ltalirz and others added 2 commits May 18, 2020 23:52
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
@ltalirz ltalirz force-pushed the docs-howto-plugins branch from c53d4b0 to baa0b6d Compare May 18, 2020 22:09
@ltalirz ltalirz requested a review from csadorf May 18, 2020 22:09
@ltalirz
Copy link
Member Author

ltalirz commented May 18, 2020

Thanks @csadorf for the thorough read, from my side this would be ready to be merged
(remaining updates in the "Interfacing external codes" can be dealt with by the PR focusing on this section).

@csadorf csadorf merged commit 2005719 into aiidateam:docs-revamp May 19, 2020
csadorf added a commit that referenced this pull request May 29, 2020
Add "How to package plugins":

 * add "Creating a plugin package"
 * add "Adding entry points"
 * add "Testing a plugin package"
 * add "Documenting a plugin package"
 * add "Publishing a plugin package"

Also start adding the "plugins" topical guide.

Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants