Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move in place three sections to docs "How-to" (in Managing your installation) #4074

Merged

Conversation

giovannipizzi
Copy link
Member

In particular, moving:

how-to:tune performance (fixes #4002)
how-to:update installation (fixes #4003)
how-to:backup (fixes #4004)

I'm doing these in a single commit since they are closely related (especially for what concerns links)

@giovannipizzi giovannipizzi requested a review from csadorf May 15, 2020 10:45
@giovannipizzi
Copy link
Member Author

The only question I have is the folder installation_more where I put additional files that I think should be in a different page, otherwise the page becomes too long with not-so-critical details.

Suggestions for a different name (or different location) are welcome.

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some general suggestions on how to improve the style and maybe make the content a bit more concise.

For some of the content, especially the backup section with O/S specific instructions, I make suggestions on how to either move or place it such that it does not impede the general flow and is better separated from content that is more generally applicable. I think we should aim at streamlining these sections such that they remain clearly problem-oriented. See my specific comments for details.

I also suggest to introduce a new top-level how-to section on "how to run on clusters". While very relevant for users that do run on clusters, I think it is obstructive for those that don't, so a better separation is probably desirable. It will also help cluster users find the related content more easily.

docs/source/howto/data.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Show resolved Hide resolved
docs/source/howto/installation_more/for_cluster_admins.rst Outdated Show resolved Hide resolved
docs/source/howto/installation_more/index.rst Outdated Show resolved Hide resolved
@csadorf csadorf linked an issue May 20, 2020 that may be closed by this pull request
@giovannipizzi
Copy link
Member Author

Thanks @csadorf, I'll apply the rest of the comments (mostly involving moving stuff around) tomorrow. Sorry also for the many commits, I didn't get at the beginning how to batch suggestions together (was working from the discussion pane and not from the files pane).
Anyway this will be squash-merged, or maybe when working on the rest I'll already rebase.

@giovannipizzi giovannipizzi changed the title Move in place three sections to docs "How-to" Move in place three sections to docs "How-to" (in Managing your installation) May 25, 2020
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @giovannipizzi

I added two comments I had written down for myself to fix at some point.
They are easy to address.

docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
@giovannipizzi giovannipizzi force-pushed the fix_4001_docs_manage_installation branch from 88c17ac to b55373d Compare May 25, 2020 10:35
@csadorf
Copy link
Contributor

csadorf commented May 25, 2020

@giovannipizzi Is this ready for another round of review?

@giovannipizzi giovannipizzi force-pushed the fix_4001_docs_manage_installation branch from b55373d to addd83c Compare May 25, 2020 10:44
@giovannipizzi
Copy link
Member Author

Hi!
I was just going to ping you, I just needed to do a force push because I noticed a small problem.
I also reorganised the commits, there are only two now.
I now addressed all comments (I think) and it's ready to be reviewed again! Thanks

@csadorf csadorf self-requested a review May 25, 2020 11:05
@giovannipizzi
Copy link
Member Author

@csadorf FYI I'm going to add a new short section that was just contributed by Nicola Spallanzani, as it fits in here; I'm also going to rebase so you can check on CircleCI

@giovannipizzi giovannipizzi force-pushed the fix_4001_docs_manage_installation branch from c0a2c6e to 414fa83 Compare May 25, 2020 12:57
@giovannipizzi
Copy link
Member Author

@csadorf OK, done!

docs/source/howto/backup_postgresql.sh Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Outdated Show resolved Hide resolved
docs/source/howto/installation.rst Show resolved Hide resolved
docs/source/howto/load-singlesshagent.sh Show resolved Hide resolved
@csadorf csadorf linked an issue May 25, 2020 that may be closed by this pull request
@giovannipizzi giovannipizzi force-pushed the fix_4001_docs_manage_installation branch from 395802f to 2709757 Compare May 25, 2020 21:16
giovannipizzi and others added 4 commits May 25, 2020 23:16
…ections:

how-to:tune performance (fixes aiidateam#4002)
how-to:update installation (fixes aiidateam#4003)
how-to:backup (fixes aiidateam#4004)

I'm doing these in a single commit since they are closely related (especially for what concerns links)
Some reorganisation of content and some rewording

Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
Co-authored-by: Nicola Spallanzani <nicola.spallanzani@max-centre.eu>
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
@giovannipizzi giovannipizzi force-pushed the fix_4001_docs_manage_installation branch from 2709757 to ccf2487 Compare May 25, 2020 21:17
@giovannipizzi giovannipizzi requested a review from csadorf May 25, 2020 21:17
@giovannipizzi
Copy link
Member Author

@csadorf comments addressed (or commented/replied above) - this is now ready for re-review

Comment on lines +279 to +281
- `Additional instructions on how to migrate from 0.12.x versions <https://aiida.readthedocs.io/projects/aiida-core/en/v1.2.1/install/updating_installation.html#updating-from-0-12-to-1>`_.
- `Additional instructions on how to migrate from versions 0.4 -- 0.11 <https://aiida.readthedocs.io/projects/aiida-core/en/v1.2.1/install/updating_installation.html#older-versions>`_.
- For a list of breaking changes between the 0.x and the 1.x series of AiiDA, check `this page <https://aiida.readthedocs.io/projects/aiida-core/en/v1.2.1/install/updating_installation.html#breaking-changes-from-0-12-to-1>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other approach to this is to keep move these sections to e.g. docs/source/howto/_version_migrations.rst and link to that.
Then at the top of that document put :orphan:; this tells sphinx that the document is not required to show up in any ToC. This is what I have currently done in #4060 (see https://7-77234579-gh.circle-artifacts.com/0/html/intro/installation.html#updating-aiida-core), but I will remove that section and link here

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@csadorf csadorf merged commit 69bfba3 into aiidateam:docs-revamp May 26, 2020
chrisjsewell added a commit to chrisjsewell/aiida_core that referenced this pull request May 26, 2020
csadorf added a commit that referenced this pull request May 29, 2020
Add how-to sections for:

how-to:tune performance (fixes #4002)
how-to:update installation (fixes #4003)
how-to:backup (fixes #4004)
how-to:installation:running-on-supercomputers

Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
Co-authored-by: Nicola Spallanzani <nicola.spallanzani@max-centre.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: How to update your installation Docs: How to tune performance
4 participants