-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow profile selection ipython magic %aiida #4071
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4071 +/- ##
===========================================
+ Coverage 78.57% 78.76% +0.20%
===========================================
Files 461 463 +2
Lines 34095 34402 +307
===========================================
+ Hits 26787 27094 +307
Misses 7308 7308
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! Thanks @zhubonan.
I have a small comment/question though, see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @zhubonan - I think this is a great and simple addition
just two minor nitpicks.
no further need for review from my side after this; can then be merged
@ltalirz I have just tweaked the documentation accordingly. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @zhubonan !
Fixes #4095
A small change in the ipython
%aiida
magic to allow selection of the profile. The name of the profile is echoed back so the user knows what they are using.