Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow profile selection ipython magic %aiida #4071

Merged
merged 5 commits into from
May 14, 2020
Merged

Allow profile selection ipython magic %aiida #4071

merged 5 commits into from
May 14, 2020

Conversation

zhubonan
Copy link
Contributor

@zhubonan zhubonan commented May 14, 2020

Fixes #4095

A small change in the ipython %aiida magic to allow selection of the profile. The name of the profile is echoed back so the user knows what they are using.

@zhubonan zhubonan requested a review from ltalirz May 14, 2020 08:41
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #4071 into develop will increase coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4071      +/-   ##
===========================================
+ Coverage    78.57%   78.76%   +0.20%     
===========================================
  Files          461      463       +2     
  Lines        34095    34402     +307     
===========================================
+ Hits         26787    27094     +307     
  Misses        7308     7308              
Flag Coverage Δ
#django 70.67% <0.00%> (+0.08%) ⬆️
#sqlalchemy 71.55% <0.00%> (+0.11%) ⬆️
Impacted Files Coverage Δ
aiida/tools/ipython/ipython_magics.py 0.00% <0.00%> (ø)
aiida/tools/importexport/dbexport/__init__.py 97.72% <0.00%> (-1.39%) ⬇️
aiida/cmdline/commands/cmd_import.py 77.50% <0.00%> (-0.08%) ⬇️
aiida/tools/importexport/common/config.py 100.00% <0.00%> (ø)
aiida/tools/importexport/common/exceptions.py 100.00% <0.00%> (ø)
...iida/tools/importexport/dbimport/backends/utils.py
aiida/tools/importexport/common/progress_bar.py 83.34% <0.00%> (ø)
aiida/backends/utils.py 95.00% <0.00%> (ø)
aiida/tools/importexport/dbimport/utils.py 82.90% <0.00%> (ø)
aiida/common/folders.py 82.06% <0.00%> (+0.52%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d4bbe...49912dc. Read the comment docs.

Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! Thanks @zhubonan.

I have a small comment/question though, see below.

aiida/tools/ipython/ipython_magics.py Show resolved Hide resolved
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zhubonan - I think this is a great and simple addition

just two minor nitpicks.

no further need for review from my side after this; can then be merged

docs/source/install/configuration.rst Outdated Show resolved Hide resolved
docs/source/install/configuration.rst Outdated Show resolved Hide resolved
@zhubonan
Copy link
Contributor Author

zhubonan commented May 14, 2020

@ltalirz I have just tweaked the documentation accordingly. Thanks.

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zhubonan !

@ltalirz ltalirz merged commit 9d9d095 into aiidateam:develop May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow profile selection ipython magic %aiida
3 participants