-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add "How to - Configuring your installation" #4068
Docs: add "How to - Configuring your installation" #4068
Conversation
Two things here:
|
I think it should be mentioned somewhere that using the same code (virtualenv) for different |
Good point. This is more or less implied by the later detailed explanation that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made various suggestions for improving the style of this section and fixed a few errors, but content looks overall fine to me.
docs/source/howto/installation.rst
Outdated
.. important:: | ||
|
||
After you have added the line to the start up script, make sure to restart the terminal or source the script for the changes to take effect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the .. important::
directive require two empty lines surrounding it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't require anything different from the other markup marks such as .. note::
but I see just a single empty line. Did you mean two linebreaks? I personally like the empty line for readability, but happy to change. What would the standard be? Directly following the mark, or a single linebreak? I guess the former would become problematic if the note contains multiple sentences. So I would vote for either 1 or 2 linebreaks
@csadorf what do you think about my question regarding the order of this section and that of my other PR. Would you agree that it makes sense to swap the current order and put this one first and the "Managing profiles" second? |
I think it depends on what we consider a more widely applicable scenario:
I'm assuming it's #1 for the expert user and #2 for the average user, what do you think? |
This is the problem though, #1 is not necessarily just for expert users. Since we always recommend the use of virtual environments, the information of the There is even a comment from a user on #4001 that suggest that this information should be close to the installation. I am not convinced that we should, but it does show that it might be valuable information also for starting users with a single instance. Of course, not knowing about |
@sphuber I think you misunderstood my comment. I did not want to imply that #1 is only applicable for expert aiida users nor that #2 is only applicable to average aiida users. What I'm asking is: which scenario you are more likely to encounter as the average user? That should drive the order of these two sections. |
@csadorf I see. Well, I guess parts of part 2 (enabling tab-completion and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question, otherwise good to go.
|
||
.. warning:: | ||
|
||
If there was no ``.aiida`` directory in ``~/project_a``, AiiDA would have created it for you, so make sure to set the ``AIIDA_PATH`` correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by this warning. Why do I need to worry about this?
Would the following warning be correct?
If there was no ``.aiida`` directory in ``~/project_a``, AiiDA would have created it for you, so make sure to set the ``AIIDA_PATH`` correctly. | |
AiiDA will create the ``.aiida`` directory in ``~/project_a`` in case that it does not exist yet. |
Or is the warning related to the fact that it will create the complete path and not only the .aiida/
leaf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "problem" is that AiiDA will create the folder silently if it does not exist and will not raise an error. If a user, by accident, specifies the wrong path, the folder will be created in a different path then expected. Not that this will have grave consequences but it might be unexpected.
This section describes how multiple instances of AiiDA can be isolated on the same machine, how tab-completion can be activated and how the `verdi config` command can be used to configure profile options. Except for the `verdi config` section, which is completely new, the other content has been adapted from existing documentation.
6597690
to
e3b9fa0
Compare
This section describes how multiple instances of AiiDA can be isolated on the same machine, how tab-completion can be activated and how the `verdi config` command can be used to configure profile options. Except for the `verdi config` section, which is completely new, the other content has been adapted from existing documentation.
Fixes #4001
This section describes how multiple instances of AiiDA can be isolated
on the same machine, how tab-completion can be activated and how the
verdi config
command can be used to configure profile options.Except for the
verdi config
section, which is completely new, theother content has been adapted from existing documentation.