Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add the "How to work with data - Importing data" section #4045

Merged
merged 1 commit into from
May 7, 2020
Merged

Docs: add the "How to work with data - Importing data" section #4045

merged 1 commit into from
May 7, 2020

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 3, 2020

Fixes #3994

@codecov
Copy link

codecov bot commented May 3, 2020 •
edited
Loading

Codecov Report

Merging #4045 into docs-revamp will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           docs-revamp    #4045   +/-   ##
============================================
  Coverage        78.45%   78.45%           
============================================
  Files              461      461           
  Lines            34077    34077           
============================================
  Hits             26732    26732           
  Misses            7345     7345
Flag Coverage Δ
#django 70.49% <ø> (ø)
#sqlalchemy 71.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb3995c...45c3961. Read the comment docs.

@csadorf csadorf self-requested a review May 6, 2020 14:48
csadorf
csadorf approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few suggestions, but otherwise LGTM. Please accept/ reject at your discretion, otherwise ready to merge.

docs/source/howto/data.rst Show resolved Hide resolved
docs/source/howto/data.rst Outdated Show resolved Hide resolved
docs/source/howto/data.rst Outdated Show resolved Hide resolved
docs/source/howto/data.rst Outdated Show resolved Hide resolved
docs/source/howto/data.rst Outdated Show resolved Hide resolved
@sphuber sphuber force-pushed the fix/3994/docs-howto-import-data branch from e9b1c9c to 6f0d663 Compare May 7, 2020 10:24
@sphuber
Copy link
Contributor Author

sphuber commented May 7, 2020

Thanks for the review @csadorf . I have applied all your suggestions

@sphuber sphuber force-pushed the fix/3994/docs-howto-import-data branch from 6f0d663 to 45c3961 Compare May 7, 2020 10:31
@sphuber sphuber merged commit 1c2a9ab into aiidateam:docs-revamp May 7, 2020
@sphuber sphuber deleted the fix/3994/docs-howto-import-data branch May 7, 2020 10:46
@sphuber sphuber mentioned this pull request May 7, 2020
Closed
csadorf pushed a commit that referenced this pull request May 29, 2020
@sphuber @csadorf
Docs: How to work with data - Importing data (#4045)
13e34fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sphuber @csadorf