Ensure log messages are not duplicated in daemon log file #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging for the daemon was configured with a handler both for writing to stdout `console` as well as a rotating file handler that writes directly to the daemon log file. The last one is the intended one but since the default `console` handler was also kept, its output also ended up in the daemon log file, duplicating every message.
Codecov Report
@@ Coverage Diff @@
## develop #3890 +/- ##
===========================================
- Coverage 77.17% 70.02% -7.15%
===========================================
Files 457 457
Lines 33774 33778 +4
===========================================
- Hits 26065 23653 -2412
- Misses 7709 10125 +2416
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3889
The logging for the daemon was configured with a handler both for
writing to stdout
consoleas well as a rotating file handler thatwrites directly to the daemon log file. The last one is the intended one
but since the default
consolehandler was also kept, its output alsoended up in the daemon log file, duplicating every message.