Make command line deprecation warnings visible with test profile #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `deprecated_command` decorator was only printing the warning if the profile was not a test profile. With `verdi devel tests` being deprecated, typically run with a test profile, the warning was being swallowed. This change gave problems with a test of `verdi comment show` that expected no output for no input, but now of course failed due to the output of the deprecation. Since it is a deprecated command anyway I simply remove the test.
sphuber
force-pushed
the
fix_verdi_devel_tests_deprecated
branch
from
0fd104c to
eac4d84
Compare
|
@ltalirz I had to update it a bit because the tests failed |
giovannipizzi
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deprecated_commanddecorator was only printing the warning if theprofile was not a test profile. With
verdi devel testsbeingdeprecated, typically run with a test profile, the warning was being
swallowed.