-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial prototype for scheduler parsing #3647
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espenfl
force-pushed
the
slurm_parser
branch
from
December 12, 2019 15:35
2e52ebb
to
68b05f6
Compare
sphuber
requested changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @espenfl great first start, I have a few comments. Also the logic on which exit code to give priority should probably be discussed, in person would be most efficient I think
espenfl
force-pushed
the
slurm_parser
branch
from
December 12, 2019 18:36
3e63fdf
to
5806ac4
Compare
espenfl
force-pushed
the
slurm_parser
branch
from
December 12, 2019 19:01
5806ac4
to
b7a754e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an initial approach which enable basic scheduler parsing. The Slurm scheduler is used as an example. For Slurm, the
State
entry in thesacct
contains for instanceOUT_OF_MEMORY
when the process breach the set memory limit. As such it makes sense to parse thesacct
information and in case needed, map that to generic error codes.There is also a method to parse the
stdout
andstderr
of the parser, which in this commit does nothing. Currently the error code with the highestexit_status
number is set (in case there are differences between thesacct
and file approach.Currently, exit codes are set on
JobCalc
. We might, in the future consider to move the same framework onto the scheduler framework to allow for specific handling of scheduler error codes without relying on specific definitions in a givenJobCalc
.A test is also included, which sets up a node and tests the parsing for the
sacct
. We should, when functionality added, also add tests the file parsing.