support 'UNLIMITED' and 'NOT_SET' slurm times #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requested walltimes in slurm can be 'UNLIMITED' and 'NOT_SET'. now supporting these in the slurm plugin (& added tests).
sphuber
requested changes
Nov 27, 2019
There was a problem hiding this comment.
Thanks @ltalirz aside from the suggestion to change the get_job function to just creating a mapping once and indexing that, this is good for me. However, I would like @greschd and @giovannipizzi to weigh in on the final choice of values for UNLIMITED and NOT_SET
| @@ -46,43 +54,46 @@ def test_parse_common_joblist_output(self): | |||
|
|
|||
| job_list = scheduler._parse_joblist_output(retval, stdout, stderr) | |||
|
|
|||
| def get_job(id): | |||
| try: | |||
There was a problem hiding this comment.
Probably be a bit easier and more efficient to just turn job_list into a mapping on job_id and then index that in the tests instead of doing get_job
giovannipizzi
approved these changes
Nov 28, 2019
|
Looks good to me, too. Thanks for implementing this! |
sphuber
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3415
requested walltimes in slurm can be 'UNLIMITED' and 'NOT_SET'.
now supporting these in the slurm plugin (& added tests).