Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an index to columns of DbLink for SqlAlchemy #2561

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Mar 4, 2019

Fixes #2557

Indices are added for the input_id, output_id and type column of
the DbLink model for SqlAlchemy. This makes it congruent with the
Django model and ensures that the engine will not grind to a halt for
bigger production databases which often needs to get all incoming or
outgoing links for a node.

@sphuber sphuber requested a review from giovannipizzi March 4, 2019 15:58
Indices are added for the `input_id`, `output_id` and `type` column of
the `DbLink` model for SqlAlchemy. This makes it congruent with the
Django model and ensures that the engine will not grind to a halt for
bigger production databases which often needs to get all incoming or
outgoing links for a node.
@sphuber sphuber force-pushed the fix_2557_indices_dblink branch from 96b95fa to 99a10f5 Compare March 4, 2019 16:27
@coveralls
Copy link

coveralls commented Mar 4, 2019

Coverage Status

Coverage increased (+3.6%) to 70.318% when pulling 99a10f5 on sphuber:fix_2557_indices_dblink into 1b5b269 on aiidateam:provenance_redesign.

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essential!

@sphuber sphuber merged commit 2c89388 into aiidateam:provenance_redesign Mar 4, 2019
@sphuber sphuber deleted the fix_2557_indices_dblink branch March 4, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants