Add framework for migration tests in SQLAlchemy #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
force-pushed
the
fix_2391_sqla_migrations_tests
branch
from
363e03e to
6f95622
Compare
giovannipizzi
force-pushed
the
fix_2391_sqla_migrations_tests
branch
from
6f95622 to
23856e3
Compare
This fixes aiidateam#2391. In particular it adds a framework for testing migrations in SQLAlchemy/Alembic, and ports one test from Django, also to act as an example and to verify that the migration testing is properly working. I've also removed old files that were running some tests but actually were just running on a set of example migrations and not on those of AiiDA.
giovannipizzi
force-pushed
the
fix_2391_sqla_migrations_tests
branch
from
23856e3 to
50a58d7
Compare
sphuber
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2391. In particular it adds a framework for testing migrations
in SQLAlchemy/Alembic, and ports one test from Django, also to act as an
example and to verify that the migration testing is properly working.
I've also removed old files that were running some tests but actually were just
running on a set of example migrations and not on those of AiiDA.