Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implementation of legacy workflows #2379

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jan 11, 2019

Fixes #2378

Note that the database models are kept in place as they will be removed
later, because it will require a migration that will drop the tables.
However, we want to include some functionality that allows the user to
dump the content for storage, before having the migration executed.

@sphuber sphuber requested a review from giovannipizzi January 11, 2019 08:43
@sphuber sphuber force-pushed the fix_2378_drop_legacy_workflows branch from 54531b9 to 9e3ccaf Compare January 11, 2019 11:45
@coveralls
Copy link

Coverage Status

Coverage decreased (-6.5%) to 62.523% when pulling 9e3ccaf13ca275e2a2354607e9d3c1df369182e2 on sphuber:fix_2378_drop_legacy_workflows into 1e339c3 on aiidateam:provenance_redesign.

@coveralls
Copy link

coveralls commented Jan 11, 2019

Coverage Status

Coverage decreased (-0.3%) to 68.692% when pulling 4b75183 on sphuber:fix_2378_drop_legacy_workflows into 1e339c3 on aiidateam:provenance_redesign.

@sphuber sphuber force-pushed the fix_2378_drop_legacy_workflows branch from 9e3ccaf to c7a7d4a Compare January 11, 2019 12:13
Note that the database models are kept in place as they will be removed
later, because it will require a migration that will drop the tables.
However, we want to include some functionality that allows the user to
dump the content for storage, before having the migration executed.
@sphuber sphuber force-pushed the fix_2378_drop_legacy_workflows branch from c7a7d4a to 4b75183 Compare January 11, 2019 12:36
@sphuber
Copy link
Contributor Author

sphuber commented Jan 11, 2019

@giovannipizzi I put the models back so the tests are running now without having to drop the tables. The django test on Jenkins is failing but this I think because it used an old cache of the database of the first run that had the tables dropped. The same test runs fine on Travis.

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why it's reusing the DB, by looking at the code I couldn't understand it. Also it is a bit strange that it's actually triggering the issue during a cascading (we're actually deleting DbNode) - apparently the cascading is done by Django I believe.

Anyway, let's merge - it does feel good, doesn't it? ;-)

@sphuber sphuber merged commit cd2b051 into aiidateam:provenance_redesign Jan 11, 2019
@sphuber sphuber deleted the fix_2378_drop_legacy_workflows branch January 11, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants