Migrate the type and process type string of built in calculation plugins #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_2306_migrate_builtin_calculation_entry_points
branch
from
5a9d7c3 to
d7d343c
Compare
giovannipizzi
requested changes
Dec 6, 2018
| WHERE type = 'calculation.job.simpleplugins.templatereplacer.TemplatereplacerCalculation.'; | ||
|
|
||
| UPDATE db_dbnode SET process_type = 'aiida.calculation:arithmetic.add' | ||
| WHERE process_type = 'aiida.calculation:simpleplugins.arithmetic.add' |
| WHERE process_type = 'aiida.calculation:simpleplugins.arithmetic.add' | ||
|
|
||
| UPDATE db_dbnode SET process_type = 'aiida.calculation:templatereplacer' | ||
| WHERE process_type = 'aiida.calculation:simpleplugins.templatereplacer' |
| WHERE process_type = 'aiida.calculation:simpleplugins.templatereplacer'; | ||
|
|
||
| UPDATE db_dbattribute SET tval = 'arithmetic.add' | ||
| WHERE key = 'input_plugin' AND tval = 'simpleplugins.arithmetic.add'; |
There was a problem hiding this comment.
Needs a Join on Db_Dbnode to do the same as SQLA
|
Also, there is a pre-commit thing to fix |
sphuber
force-pushed
the
fix_2306_migrate_builtin_calculation_entry_points
branch
2 times, most recently
from
7c0d05c to
95ad6b2
Compare
The built in calculation entry points were recently moved and renamed but no migration was put in. This requires renaming the node types, process types and the input plugin attribute of code instances.
sphuber
force-pushed
the
fix_2306_migrate_builtin_calculation_entry_points
branch
from
95ad6b2 to
c6e5381
Compare
giovannipizzi
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2306
The built in calculation entry points were recently moved and renamed
but no migration was put in.
This requires renaming the node types, process types and the input plugin
attribute of code instances.