Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize verdi profile delete #2151

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Modularize verdi profile delete #2151

merged 1 commit into from
Jan 14, 2019

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Nov 4, 2018 •
edited by sphuber
Loading

fix #2121

  • add 3 options to verdi profile delete:
    • --include-db/--skip-db
    • --include-repository/--skip-repository
    • --include-config/--skip-config
  • split into delete_repository, delete_db, delete_from_config
  • move functions into aiida.control.profile

To do:

@coveralls
Copy link

coveralls commented Nov 4, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 68.54% when pulling c0be528 on ltalirz:issue_2121_test_profile_delete into cd2b051 on aiidateam:provenance_redesign.

@giovannipizzi giovannipizzi changed the title modularize verdi profile delete [WIP] modularize verdi profile delete Nov 10, 2018
@giovannipizzi
Copy link
Member

I guess this is still not ready to merge, right? I added [WIP] in the title (and added some comments to #2121)

@sphuber sphuber force-pushed the issue_2121_test_profile_delete branch from 9794a44 to e8a356a Compare December 5, 2018 22:32
@sphuber sphuber changed the base branch from develop to provenance_redesign December 5, 2018 22:33
@sphuber sphuber force-pushed the issue_2121_test_profile_delete branch from e7aa941 to 69f0a13 Compare January 14, 2019 10:38
@ltalirz @sphuber
Modularize verdi profile delete
c0be528 
Modularized the code to delete a profile by splitting it into functions that
have been moved to `aiida.manage.configuration.setup` module. Then, three new
options are added to `verdi profile delete`

 * `--include-db/--skip-db`
 * `--include-repository/--skip-repository`
 * `--include-config/--skip-config`

The unittest for `verdi profile delete` now makes use of `--skip-db` such that
the test no longer prompts for a sudo password locally. The full functionality
is tested on Travis in `.ci/test_profile.py`.
@sphuber sphuber force-pushed the issue_2121_test_profile_delete branch from 69f0a13 to c0be528 Compare January 14, 2019 10:54
@sphuber sphuber changed the title [WIP] modularize verdi profile delete Modularize verdi profile delete Jan 14, 2019
@sphuber sphuber requested a review from giovannipizzi January 14, 2019 11:18
@sphuber
Copy link
Contributor

sphuber commented Jan 14, 2019

I fixed the remaining open to do checkpoint and rebased onto provenance_redesign. Should be good to go

@ltalirz
Copy link
Member Author

ltalirz commented Jan 14, 2019

thanks a lot @sphuber
I think you can even approve it (I cannot since I opened the PR)

@giovannipizzi giovannipizzi merged commit 69f3bd5 into aiidateam:provenance_redesign Jan 14, 2019
@giovannipizzi
Copy link
Member

By merging (squash and merge - I thought it was ok as there was only 1 commit) I removed the attribution of @sphuber and left only the one of @ltalirz - sorry @sphuber about that!)

@sphuber
Copy link
Contributor

sphuber commented Jan 14, 2019

No problem whatsoever, just rebasing and fixing merge problems, hardly deserves attribution

@sphuber sphuber mentioned this pull request Jan 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannipizzi giovannipizzi giovannipizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ltalirz @coveralls @giovannipizzi @sphuber