updated io tree response to add link type information #2033
Conversation
aiida/restapi/translator/node.py
Outdated
| @@ -596,6 +597,7 @@ def get_node_shape(ntype): | |||
| "displaytype": display_type, | |||
| "group": "inputs", | |||
| "description": description, | |||
| "linklabel": linklabel, | |||
There was a problem hiding this comment.
I don't think the linklabel should be attached to the nodes, but to the edges
There was a problem hiding this comment.
This information is used in materials cloud when user mouse hover on node. So it needs to be passed in node.
| @@ -604,20 +606,21 @@ def get_node_shape(ntype): | |||
| "to": 0, | |||
| "arrows": "to", | |||
| "color": {"inherit": 'from'}, | |||
| "linktype": linktype, | |||
| "label": linktype, | |||
There was a problem hiding this comment.
The linklabel should be moved here from nodes, and this should remain to be called linktype
There was a problem hiding this comment.
'label' is the name used by JS library to display value on edge. This endpoint is specifically written for materials cloud and passes the data in format used in MC. Otherwise we can reprocess the data completely in frontend again before passing it to the visualization library.
aiida/restapi/translator/node.py
Outdated
| @@ -634,6 +637,7 @@ def get_node_shape(ntype): | |||
| "displaytype": display_type, | |||
| "group": "outputs", | |||
| "description": description, | |||
| "linklabel": linklabel, | |||
| @@ -642,7 +646,7 @@ def get_node_shape(ntype): | |||
| "to": nodeCount, | |||
| "arrows": "to", | |||
| "color": {"inherit": 'to'}, | |||
| "linktype": linktype | |||
| "label": linktype | |||
|
@waychal you can merge this when tests finish to run. |
No description provided.