Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin dev docs: migrate to plugin cutter #1904

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Aug 23, 2018

migrating from outdated aiida-plugin-template to more comfortable
plugin cutter.

migrating from outdated aiida-plugin-template to more comfortable
plugin cutter.
@codecov-io
Copy link

Codecov Report

Merging #1904 into release_v0.12.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release_v0.12.2    #1904   +/-   ##
================================================
  Coverage            54.51%   54.51%           
================================================
  Files                  246      246           
  Lines                32602    32602           
================================================
  Hits                 17772    17772           
  Misses               14830    14830

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 915dcf9...379e273. Read the comment docs.

@ltalirz ltalirz requested a review from giovannipizzi August 24, 2018 15:34
Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Do you think we should remove the aiida-plugin-template repository and remove it also from the aiida-registry?

@ltalirz ltalirz merged commit 107ada8 into aiidateam:release_v0.12.2 Aug 24, 2018
@ltalirz
Copy link
Member Author

ltalirz commented Aug 24, 2018

Good point - I've already added a warning on the readme of the plugin template (I'd say we keep it around for a bit longer) but I forgot to remove it from the plugin registry.
I will add the aiida-diff demo plugin there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants