Fix bug in the RemoteData._clean method #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `clean_remote` free function was not imported. Fix the import, and add a test to trigger this code path. As a result, a bug was found in the AuthInfo and User backend implementations, where the wrong type for `backend` argument were being passed to the constructor by the Collection.
Codecov Report
@@ Coverage Diff @@
## develop #1847 +/- ##
===========================================
+ Coverage 66.7% 66.82% +0.12%
===========================================
Files 317 316 -1
Lines 32406 32309 -97
===========================================
- Hits 21616 21592 -24
+ Misses 10790 10717 -73
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1844
The
clean_remotefree function was not imported. Fix the import,and add a test to trigger this code path. As a result, a bug was
found in the AuthInfo and User backend implementations, where the
wrong type for
backendargument were being passed to the constructorby the Collection.