Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate verdi devel to the click infrastructure #1765

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jul 19, 2018

Fixes #1585

Removed several commands that were outdated and no longer in use

* verdi devel query
* verdi devel getresults

The former was still under development and hardcoded Django queries and so was
not usable across all backends. The latter was also in development stage and
has now been replaced by the more apt verdi calculation res command.

@sphuber sphuber requested a review from giovannipizzi July 19, 2018 07:20
Removed several commands that were outdated and no longer in use

	* verdi devel query
	* verdi devel getresults

The former was still under development and hardcoded Django queries and so was
not usable across all backends. The latter was also in development stage and
has now been replaced by the more apt `verdi calculation res` command.
@sphuber sphuber force-pushed the fix_1585_migrate_verdi_devel branch from 6556c82 to 58199d9 Compare July 19, 2018 07:55
@codecov-io
Copy link

Codecov Report

Merging #1765 into verdi will increase coverage by 0.74%.
The diff coverage is 76.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##            verdi    #1765      +/-   ##
==========================================
+ Coverage   64.32%   65.07%   +0.74%     
==========================================
  Files         312      312              
  Lines       33144    32853     -291     
==========================================
+ Hits        21321    21379      +58     
+ Misses      11823    11474     -349
Impacted Files Coverage Δ
aiida/cmdline/commands/devel.py 76.64% <76.5%> (+55.46%) ⬆️
aiida/common/log.py 75% <0%> (-2.09%) ⬇️
aiida/cmdline/utils/decorators.py 65.51% <0%> (+3.44%) ⬆️
aiida/common/setup.py 55.34% <0%> (+5.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7cdd0...58199d9. Read the comment docs.

@sphuber sphuber merged commit 46a16b8 into verdi Jul 19, 2018
@sphuber sphuber deleted the fix_1585_migrate_verdi_devel branch July 19, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants