Migrate verdi calculation to use the click infrastructure
#1667
Conversation
sphuber
force-pushed
the
fix_1579_migrate_verdi_calculation
branch
3 times, most recently
from
fa52e06 to
8255d0f
Compare
sphuber
force-pushed
the
fix_1579_migrate_verdi_calculation
branch
from
8255d0f to
431e9d1
Compare
Codecov Report
@@ Coverage Diff @@
## verdi #1667 +/- ##
==========================================
+ Coverage 59.63% 60.17% +0.54%
==========================================
Files 295 294 -1
Lines 34594 34065 -529
==========================================
- Hits 20629 20500 -129
+ Misses 13965 13565 -400
Continue to review full report at Codecov.
|
|
This PR is ready and the tests are passing. @giovannipizzi @DropD ready for review |
.pre-commit-config.yaml
Outdated
| aiida/orm/data/cif.py| | ||
| aiida/restapi/resources.py| | ||
| aiida/restapi/translator/data/cif.py| | ||
| aiida/utils/fixtures.py | ||
| aiida/utils/fixtures.py| | ||
| docs/update_req_for_rtd.py| # a|b -> match a OR b |
There was a problem hiding this comment.
I'm not sure it should finish with a vertical pipe |
There was a problem hiding this comment.
Only for that line, or for all of them?
There was a problem hiding this comment.
If I understand the syntax, the | is an "OR" so it should be everywhere except the last line (btw I'm still not convinced that the syntax is perfectly ok - e.g. the dot probably matches any character?)
There was a problem hiding this comment.
Ah, yes I did not recognize that you meant the last line. I think you are right and I removed it. The dot should indeed match any character. I tried removing it before the wildcard and then it does not match anything. It really seems to work like a regex pattern then
.pre-commit-config.yaml
Outdated
| aiida/utils/fixtures.py | ||
| aiida/restapi/translator/data/cif.py| | ||
| aiida/utils/fixtures.py| | ||
| docs/update_req_for_rtd.py| |
| @@ -50,7 +50,6 @@ class JobCalculationFinishStatus(enum.Enum): | |||
| RETRIEVALFAILED = 200 | |||
| PARSINGFAILED = 300 | |||
| FAILED = 400 | |||
| I_AM_A_TEAPOT = 418 | |||
There was a problem hiding this comment.
Interesting old state ;-)
There was a problem hiding this comment.
Yeah, I put that in when it was still the workflows branch. Thought it best to just remove it now before someone gets hurt :)
| @@ -48,6 +48,17 @@ def test_basic(self): | |||
| with LocalTransport(): | |||
| pass | |||
|
|
|||
| def test_is_open(self): | |||
There was a problem hiding this comment.
This test should probably be defined in test_all_plugins.py with the @run_for_all_plugins decorator?
aiida/transport/plugins/test_ssh.py
Outdated
| @@ -57,6 +57,17 @@ def test_no_host_key(self): | |||
| # Reset logging level | |||
| logging.disable(logging.NOTSET) | |||
|
|
|||
| def test_is_open(self): | |||
There was a problem hiding this comment.
Same comment as the analogous test in test_local.py
Fixes #1579