Merge develop into verdi #1659
Merged
Merge develop into verdi #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Previously, this command used a fixed number of 'optional' arguments, which contained the signature of the `WorkChain` split by whitespace. By allowing whitespace in the argument, it can be passed as a single argument, making the directive stable w.r.t. adding / removing arguments in the workchain `__init__`.
The older pinned versions of sqlalchemy-migrate and pylint caused dependency requirement inconsistencies for the pbr and pylint-django indirect dependencies
The update of pylint probably triggered an error in the prospector run of the pre-commit
This was introduced when scipy 1.0.0 was released which broke the build. Now that 1.0.1 is available, which fixes that issue, the upper bound and explicit dependency is no longer needed.
adding a space, single quote and double quote to check robustness of escaping mechanism in AiiDA
use login shell to execute all remote SSH commands This has the advantage that all commands will be executed in the same environment as seen by a user loggin in onto the machine (e.g. on most UNIX systems, .profile will be sourced for login shells, while it won't be sourced for non-login shells). Additionally, calling `bash -l -c '<cmd>'` instead of `<cmd>` means that the bash shell will be used, independent of the default shell on the system. This is advantageous on systems, where bash is not the default shell (since our remote commands work only in bash).
[broke the functionality for other node type to get schema]
Added a test that would have caught this bug. For this it was necessary to set the verbosity to 2, because the bug was only triggered in the branches of code for high verbosity. Additionally, the tests created a simple graph of base Node instances, which means that the logic involving Calculation nodes and CALL links was not hit. The new test explicitly creates Calculation nodes with CALL links to test this case
Solves the issue aiidateam#1617
plugin fixtures can now be used in the unittest framework with more than one test (fix aiidateam#1425). Also, a test runner now allows to run multiple test cases without having to destroy and re-create the whole environment each time (fix aiidateam#1451).
But this time for the release 0.12.1 branch
Two export and import tests were relying on rather large export archives to test the import functionality. However, since these archives were included in the main aiida package, they would also be included in the distribution, causing the package to become unnecessarily heavy. By replacing these archives and tests with a variant that generates the test data archive on the fly, the package size will be reduced by almost have, while maintaining the same test coverage.
Also update CHANGELOG.md and ran the release helper clean scripts
…velop Merge 0.12.1 into develop
giovannipizzi
approved these changes
Jun 18, 2018
Codecov Report
@@ Coverage Diff @@
## verdi #1659 +/- ##
==========================================
- Coverage 59.12% 58.99% -0.13%
==========================================
Files 294 295 +1
Lines 34526 34615 +89
==========================================
+ Hits 20413 20422 +9
- Misses 14113 14193 +80
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.