Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibilities between dependency requirements #1488

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 7, 2018

The older pinned versions of sqlalchemy-migrate and pylint caused
dependency requirement inconsistencies for the pbr and pylint-django
indirect dependencies

sphuber added 2 commits May 7, 2018 17:35
The older pinned versions of sqlalchemy-migrate and pylint caused
dependency requirement inconsistencies for the pbr and pylint-django
indirect dependencies
The update of pylint probably triggered an error in the
prospector run of the pre-commit
@sphuber sphuber requested a review from giovannipizzi May 7, 2018 15:43
@codecov-io
Copy link

Codecov Report

Merging #1488 into release_v0.12.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release_v0.12.1    #1488   +/-   ##
================================================
  Coverage            54.42%   54.42%           
================================================
  Files                  246      246           
  Lines                32440    32440           
================================================
  Hits                 17655    17655           
  Misses               14785    14785
Impacted Files Coverage Δ
aiida/orm/data/cif.py 84.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6830fa2...19e448a. Read the comment docs.

@giovannipizzi giovannipizzi merged commit 2a69e7d into aiidateam:release_v0.12.1 May 7, 2018
@sphuber sphuber deleted the fix_dependencies_version_incompatibility branch May 8, 2018 07:12
@sphuber sphuber added this to the v0.12.1 milestone May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants