add code coverage reports #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this adds a coverage report to the individual travis runs * -a option appends output of successive runs Note: Running coverage directly via `coverage run` is recommended over fiddling with plugins, see https://stackoverflow.com/a/38243662/1069467
* codecov has problems with non-default .coverage paths, thus reverted back to placing .coverage in the aiida_core folder codecov/codecov-python#120 * adjusted color scale from 70..100 to 30..100 to provide more information on our subpar code coverage
Codecov Report
@@ Coverage Diff @@
## release_v0.12.0 #1422 +/- ##
==================================================
Coverage ? 54.42%
==================================================
Files ? 246
Lines ? 32440
Branches ? 0
==================================================
Hits ? 17655
Misses ? 14785
Partials ? 0Continue to review full report at Codecov.
|
sphuber
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1412
This PR
I propose to not to enforce any automatic rules on coverage for the moment - let's first see whether there are any glitches.
Of course, everybody is encouraged to take this information into account when approving pull requests.