Cherry-picking 9c4a2c3f11bfcc9c59a80a6b6205169a9bf8eae9 - Sort output of verdi code list by code pk to have consistent results #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verdi work list test that compared the output with and without the -a flag was failing sometimes, simply because the order was wrong but the exact string was compared. Sorting by code id will fix the order and this breaking test
giovannipizzi
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verdi work list test that compared the output with and without
the -a flag was failing sometimes, simply because the order was
wrong but the exact string was compared. Sorting by code id will
fix the order and this breaking test