Ensure that get_inputs methods respect link_type argument for SqlAlchemy #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an error in the code which led to the link_type filter not being respected and always all input nodes would be returned
…et_inputs The link_type was specified to the _get_db_input_links, however, when cached links were also included, the link type check was not performed
The get_inputs method was using the name 'node_type' for an argument to distinguish node types, whereas get_outputs used 'type', even though logically they represented the exact same arguments. Rename the 'type' to 'node_type' for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1270
This fix is already merged into
workflowsbut it needs to be fixed in thev0.11.*release as it is breaking for people usingSqlAlchemy