Make verdi daemon stop database backend independent #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_1230_verdi_daemon_stop_db_migration
branch
from
5c1ee73 to
27ccf84
Compare
When the database needs to be migrated, the user will be presented with the instruction to call verdi daemon stop to make sure it is not running. To not have that raise the same error, it needs to run without loading the database environment. It only needs the configuration, which should also not need the backend. Note that we also had to move the definition of the USE_TZ because importing it led to the check of AIIDADB_PROFILE being set which requires the backend to be loaded, however, USE_TZ does not depend on the profile nor backend. So we just moved it out
sphuber
force-pushed
the
fix_1230_verdi_daemon_stop_db_migration
branch
from
27ccf84 to
b3fe944
Compare
DropD
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1230
When the database needs to be migrated, the user will be presented with
the instruction to call verdi daemon stop to make sure it is not running.
To not have that raise the same error, it needs to run without loading
the database environment. It only needs the configuration, which should
also not need the backend. Note that we also had to move the definition
of the USE_TZ because importing it led to the check of AIIDADB_PROFILE
being set which requires the backend to be loaded, however, USE_TZ does
not depend on the profile nor backend. So we just moved it out