Merge v0.11.0 into develop #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removing old docs that was a workaround to make sure one used RSA instead of ECDSA.
…_for_ecdsa Fix 1036 paramiko upgrade for ecdsa
update changelog for 0.11.0
The bare print messages would be picked up by the celery worker that was running the task and wrap them in a log message with a level of WARNING. This made grepping the log output for WARNINGS cluttered with false positives. Replacing them by info logs to a child logger of the AiiDA logger, will have these show up as proper log messages
…ements Replace print statements with log messages in daemon tasks
To correct the appearance of line numbers in the documentation I updated the sphinx_rtd_theme to the latest version (0.2.5b2). The bug was fixed in the version 0.2.5b1
add subcommand tab completion for data plugin commands
There is an issue with loading an old-style workflow through the
plugin system with the WorkflowFactory. There is a check in the
constructor of the Workflow class, that will check whether the
class is located in the 'aiida.workflows' module:
if caller_module == None or not caller_module.__name__.startswith("aiida.workflows"):
raise SystemError("The superclass can't be called directly")
The whole point of the plugin system is of course that subclasses
do not necessarily have to live in that module. Rather than removing
the conditional, we chose to leave it and not support old-style
workflows for the new plugin system. Since they will be soon deprecated
and no longer maintainted, doing so would give the wrong signal.
Rather, we add a note to the developer documentation in the plugin
system section, that old-style workflows are not supported
Docs addition: old-style workflows not supported by plugin system
The async function relied on the ParallelEngine of plum to launch multiple processes in parallel, however, during testing we discovered that the orm is not thread safe and race conditions could lead to unexpected behavior. The future version of plum that is currently in development for the renewed workflow engine will not support this for this reason. Therefore we remove this function here altogether in preparation for the improved workchain engine.
Remove the async function from aiida.work.run
…dthedocs Update sphinx_rtd_theme to 0.2.5b2 to fix line numbers of code snippets in docs
In a recent update, various buggy methods of the KpointsData class were deprecated. The deprecated interface would raise a ValueError if the set_kpoints_path would be called before a cell had been set, however, the deprecated methods used to allow for this, as long as the provided list used explicit reciprocal coordinates and cartesion mode was False. Always raising when a cell was not defined was therefore breaking backwards compatibility. To restore this behavior, we now pass cell=None when it is not set, to the legacy version of the get_explicit_kpoints_path method. This also required some minor changes to the helper function analyze_cell A regression test was added to verify that the old behavior was successfully restored through these changes
…ards_compatibility Allow deprecated set_kpoints_path of KpointsData without cell
* ran helper scripts * update AUTHORS.txt * checked that CHANGELOG.md is up to date * update version number in aiida/__init__.py
Release v0.11.0
Merge release v0.11.0 into master
…v0.11.0_into_develop
sphuber
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.