Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin doc/dev dependencies #4647

Closed
chrisjsewell opened this issue Jan 7, 2021 · 3 comments · Fixed by #5087
Closed

Unpin doc/dev dependencies #4647

chrisjsewell opened this issue Jan 7, 2021 · 3 comments · Fixed by #5087
Labels
topic/dependencies/constraint Issues related to dependency constraints that should be resolved.

Comments

@chrisjsewell
Copy link
Member

@csadorf in 7b03f04 I had to pin sphinx and pylint-django to less than the latest versions:

For sphinx, on CircleCI we are getting: https://app.circleci.com/pipelines/github/aiidateam/aiida-core/2403/workflows/18751484-3474-49c1-849b-4bd307cd43b8/jobs/2395

reading sources... [ 60%] reference/apidoc/aiida.restapi

Exception occurred:
  File "/home/circleci/.local/lib/python3.7/site-packages/flask/globals.py", line 38, in _lookup_req_object
    raise RuntimeError(_request_ctx_err_msg)
RuntimeError: Working outside of request context.

This typically means that you attempted to use functionality that needed
an active HTTP request.  Consult the documentation on testing for
information about how to avoid this problem.
The full traceback has been saved in /tmp/sphinx-err-0am0v1k8.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

Exited with code exit status 2

for pylint-django (see : https://github.com/aiidateam/aiida-core/runs/1657433968

pylint...................................................................Failed
- hook id: pylint
- exit code: 2

************* Module tests.manage.test_caching_config
tests/manage/test_caching_config.py:1:0: E5110: Django was not configured. For more information runpylint --load-plugins=pylint_django --help-msg=django-not-configured (django-not-configured)

------------------------------------
Your code has been rated at 10.00/10

************* Module aiida.workflows.arithmetic
aiida/workflows/arithmetic/__init__.py:1:0: E5110: Django was not configured. For more information runpylint --load-plugins=pylint_django --help-msg=django-not-configured (django-not-configured)

------------------------------------
Your code has been rated at 10.00/10

See https://github.com/PyCQA/pylint-django/blob/master/CHANGELOG.rst#version-240-06-jan-2021

these are not "production" dependencies, only for development/documentation, so I wouldn't say this is high priority

@chrisjsewell chrisjsewell added the topic/dependencies/constraint Issues related to dependency constraints that should be resolved. label Jan 7, 2021
@csadorf
Copy link
Contributor

csadorf commented Jan 8, 2021

Thank you for letting me know and creating the issue 👍 !

@chrisjsewell
Copy link
Member Author

another one to add to the list: remove astroid from pre-commit extras (added in #4757) after pylint-dev/astroid#895 fixed

@chrisjsewell chrisjsewell changed the title Unpin sphinx and pylint-django dependencies Unpin doc/dev dependencies Feb 17, 2021
@chrisjsewell
Copy link
Member Author

and some more from #4851 (pytets-cov, jupyter-client)

@csadorf csadorf removed their assignment Aug 4, 2021
chrisjsewell added a commit to chrisjsewell/aiida_core that referenced this issue Aug 18, 2021
Update pylint to v2.9 and remove restrictions on astroid and pylint-django.

- `django-not-available` -> `django-not-configured`
- Fix new `consider-using-dict-items`, `consider-using-enumerate`, `too-many-function-args`, `consider-using-from-import`, `consider-using-max-builtin`, `arguments-renamed`
- extra disables required for `no-member`
- disable `unsubscriptable-object` for cif.vaues

closes aiidateam#4647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/dependencies/constraint Issues related to dependency constraints that should be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants