Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest api: add endpoint to download ArrayData #2809

Closed
waychal opened this issue Apr 30, 2019 · 6 comments
Closed

Rest api: add endpoint to download ArrayData #2809

waychal opened this issue Apr 30, 2019 · 6 comments
Labels
Milestone

Comments

@waychal
Copy link
Contributor

waychal commented Apr 30, 2019

Currently the endpoint is provided to get general information of ArrayData but there is no endpoint available to download the raw data (numpy array) stored in ArrayData.

Add endpoint for ArrayData to get the size of the raw data and also to download it.

@JPchico
Copy link
Contributor

JPchico commented Jul 1, 2021

I was wondering if there is anything planned to address this issue? Do you know if there are any plans @chrisjsewell ?

Otherwise I would happily work on this, as it would be great to be able to gather data from ArrayData directly form the REST API.

@chrisjsewell
Copy link
Member

Heya, we are working on a whole new rest api: https://github.com/aiidateam/aiida-restapi

@JPchico
Copy link
Contributor

JPchico commented Jul 1, 2021

That is great! For what I understand it seems to be based in GraphQL? Should we move this discussion there? Would be very good to be able to access information stored in the ArrayData as JSON or similar formats so that one can visualize data from a calculation in a webservice.

@JPchico
Copy link
Contributor

JPchico commented Oct 7, 2021

@chrisjsewell there is a PR now (with passing tests) that addresses this issue. Basically a _prepare_json function that works for the orm.ArrayData. It is nothing fancy but it gets the job done :) .

@JPchico
Copy link
Contributor

JPchico commented Mar 25, 2022

Hi @sphuber I think that this issue can be closed as your PR #5425 should resolve it.
Thanks for the merge BTW!

@chrisjsewell
Copy link
Member

Cheers @JPchico, you just reminded me to email you 😅

@sphuber sphuber added this to the v2.0.0 milestone Mar 25, 2022
@sphuber sphuber added type/accepted feature approved feature request and removed type/feature request status undecided labels Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants