Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document backwards-incompatible things in 1.0.0 #2320

Closed
giovannipizzi opened this issue Dec 7, 2018 · 4 comments
Closed

Document backwards-incompatible things in 1.0.0 #2320

giovannipizzi opened this issue Dec 7, 2018 · 4 comments
Assignees
@sphuber @giovannipizzi @ConradJohnston
Labels
priority/critical-blocking must be resolved before next release
Milestone
v1.0.0b1

Comments

@giovannipizzi
Copy link
Member

giovannipizzi commented Dec 7, 2018 •
edited
Loading

Merge things with this:
https://aiida-core.readthedocs.io/en/latest/concepts/workflows.html#upgrading-workchains-from-pre-v1-0-0
and move to Install->Updating installations.

Please dump all changes in this wiki page.
@giovannipizzi giovannipizzi added the priority/critical-blocking must be resolved before next release label Dec 7, 2018
@giovannipizzi giovannipizzi added this to the v1.0.0b1 milestone Dec 7, 2018
@astamminger astamminger mentioned this issue Dec 13, 2018
Merged
@ConradJohnston ConradJohnston self-assigned this Feb 12, 2019
@ConradJohnston ConradJohnston mentioned this issue Feb 15, 2019
Merged
ConradJohnston added a commit to ConradJohnston/aiida_core that referenced this issue Feb 15, 2019
@ConradJohnston
DOCS: Create placeholder for v1.0 breaking changes
8c049ef 
Resolves aiidateam#2320

- Created a placeholder section in install/updating_installation
where the finalised prose describing all of the important behaviour changing and
backwards-incompatible change should be placed before the v1.0.0b release.
The content of this section is being drafted on the wiki at:
https://github.com/aiidateam/aiida_core/wiki/Backward-incompatible-changes-in-1.0.0
Before the beta release, the finalised content from the wiki page should be converted using
`pandoc` and then pasted in this section.

- Moved the section about converting workchains to the wiki. This section should be
included in the larger v1.0 changes text so that we don't have to maintain two seperate
versions of it.

Refer also to issue aiidateam#2482.
@sphuber
Copy link
Contributor

sphuber commented Feb 16, 2019

Fixed in PR #2483

@sphuber sphuber closed this as completed Feb 16, 2019
@giovannipizzi
Copy link
Member Author

#2482 is about moving from wiki to sphinx, that I would do in 1.0.0
I reopen this as the wiki content has not been cleaned up before the beta yet.

@giovannipizzi giovannipizzi reopened this Feb 22, 2019
@giovannipizzi giovannipizzi mentioned this issue Feb 22, 2019
Closed
@sphuber
Copy link
Contributor

sphuber commented Mar 5, 2019

I have cleaned up the list @giovannipizzi and I made today from @ConradJohnston 's original list and put it on the wiki. Since the main job is now done, and we will have to continuously update it while we find new incompatibilities, can this issue be closed?

@giovannipizzi
Copy link
Member Author

I think so. I'll close it. @ConradJohnston maybe if you have time you can double check the text and clarify if needed? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

@giovannipizzi giovannipizzi

@ConradJohnston ConradJohnston

Labels
priority/critical-blocking must be resolved before next release
Projects
None yet
Milestone
v1.0.0b1
Development

No branches or pull requests
4 participants
@sphuber @elsapassaro @giovannipizzi @ConradJohnston