documentation: line numbers in code-blocks don't match actual lines

[ltalirz]

Example: Search for "Here is the code:" on http://aiida-core.readthedocs.io/en/latest/work/index.html

This is a known bug in sphinx_rtd_theme, which has been fixed in v0.2.5
readthedocs/sphinx_rtd_theme#415

To do: Update setup_requirements.py accordingly and check that the problem is gone.

[sphuber]

Fixed in #1044

[ltalirz]

Forgot to update requirements for RTD

[ltalirz]

For the moment, it isn't fixed yet...
http://aiida-core.readthedocs.io/en/latest/work/index.html

When are the builds triggered?

[ltalirz]

There recently was a bug causing the builds on readthedocs to fail (#1143 ).
This is fixed now, and the docs build again, but the issue remains.
The reason is that, although we explicitly require sphinx-rtd-theme==0.2.5b2 (and the wheel is being downloaded!), for some reason rtd still ends up installing version 2.4:
https://readthedocs.org/projects/aiida-core/builds/6771473/

I'm ready to give up here... I guess we'll have to wait until rtd gets its act together, unless anyone else has a better idea @giovannipizzi @sphuber

[ltalirz]

@giovannipizzi I adapted the conf.py following our discussion, but without success:
http://aiida-core.readthedocs.io/en/rtd_fix/work/index.html

It's even more complicated... readthedocs/sphinx_rtd_theme#415

[giovannipizzi]

I tried some additional modifications with a local version of the theme, without success.. Probably at this point we just have to wait that RTD fixes the problem on their side... (I don't know if we want to merge the rtd_fix, as I put a local version of the theme, and this anyway does not work. We can either revert to your first commit and merge that, or just delete the branch).

[ltalirz]

On Thu, Feb 22, 2018, 08:34 Giovanni Pizzi ***@***.***> wrote: I tried some additional modifications with a local version of the theme, without success.. Probably at this point we just have to wait that RTD fixes the problem on their side...

I agree.

(I don't know if we want to merge the rtd_fix, as I put a local version of the theme, and this anyway does not work. We can either revert to your first commit and merge that, or just delete the branch).

Just delete the branch. Best, Leo

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1041 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABASPeVSG-oDX8os5KVT2srfuJsF3YJ9ks5tXRhmgaJpZM4ReV1S> .

-- Sent from mobile phone